Fix flaky Cron.updateValue test

xrutayisire / react-js-cron

A React cron editor built with antd

MIT License

238 stars 105 forks source link

🤔 This is a ...

[ ] New feature
[ ] Bug fix
[ ] Demo update
[ ] Component style update
[ ] TypeScript definition update
[ ] Bundle size optimization
[ ] Performance optimization
[ ] Refactoring
[ ] Code style optimization
[x] Test Case
[ ] README update
[ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

Fix test that occasionally fails in Cron.updateValue.test.tsx. This is due to a waitFor callback that doesn't return the expectation, causing the assertion to fail as the screen has not always updated with the expected value.

Should be applied to most other tests.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

[x] Demo in storybook is updated/provided or not needed
[x] TypeScript definition is updated/provided or not needed
[x] Tests are updated and passed without a decrease in coverage
[x] Format (lint & prettier) script passed
[x] Build script is working
[x] README API section is updated or not needed

Codecov Report

Patch and project coverage have no change.

Comparison is base (5d8585e) 84.75% compared to head (ee9d202) 84.75%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #48 +/- ## ======================================= Coverage 84.75% 84.75% ======================================= Files 12 12 Lines 492 492 Branches 197 197 ======================================= Hits 417 417 Misses 12 12 Partials 63 63 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Xavier+Rutayisire). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Xavier+Rutayisire)

xrutayisire / react-js-cron