[DS421] Proposal Feedback

xrwang / taobao-villages

CHIPS data and other fun stuff

2 stars 0 forks source link

[DS421] Proposal Feedback #2

Open dpseidel opened 6 years ago

dpseidel commented 6 years ago

Your proposal looks great Xiaowei! I took a couple peeks at some of your code and I'm excited to see you playing with reticulate. This should be a really neat project!

xrwang commented 6 years ago

@dpseidel thanks for the feedback! The overall project ended up being a bit sprawling and over the summer I will need to tidy everything up and make some r packages to reuse all the code but for now:

👉 https://github.com/xrwang/taobao-villages/blob/master/scripts/final-project.pdf has the pdf 👉 https://github.com/xrwang/taobao-villages/blob/master/scripts/final-project.md has the github flavored md, I was hoping the leaflet interactive map would work in md but unfortunately not. it looks cool locally, I swear !

LMK if I missed anything, I tried to check off most the things on the rubric 😉

Thanks for an awesome semester and for being so patient with all of us !!!

xrwang commented 6 years ago

Also I stepped away and the build started failing due to some travis secret encryption issues. I will fix when i get back to my desk, but the build is succeeding I swear ! https://travis-ci.org/xrwang/taobao-villages/jobs/376920495

dpseidel commented 6 years ago

Looks great! I know, it's a real bummer github doesn't handle html code super well! But If I get a chance I'll pull down your repo and play with it myself!

Nice work! Dana

dpseidel commented 6 years ago

Project Feedback

badge, clean repo, thorough read me. both pdf, and md formats.
:+1: integration with stata
:+1: dplyr verbs
playing with strings :+1:
:+1: leaflet/mapview, visualizations
:+1: custom functions
when using .pdf output you have to be careful with your code chunks to make sure they don't run into the margins. try to stick to les than 80 characters a line!
Wow this was a big project! nice work! A little more text would have brought the reader/user along with your results more thoroughly but it was otherwise a nice tight report. Also be careful with your markdown formatting you need some spaces to make your bullets and headers work when your introduction sections are rendered.