xsank / webssh

WebSSH is a simple web project which support login linux server with explorer.
http://xsank.github.io/webssh/
MIT License
581 stars 221 forks source link

blocking code #44

Open Libincn opened 6 years ago

Libincn commented 6 years ago

Hi, thanks for writing and releasing this application. I am trying to look into your code in recent days and have learnt a lot. I really like your coding style, clear and organized.

I have found one minor issue here about the blocking code as this app written in asynchronous way. I notice you implement a class named bridge. In WSHandler, the app calls bridge.open and it will call ssh.connect finally. And ssh.connect is a blocking function. So it will block tornado's ioloop in the main thread. I think it is not a good practice in asynchronous programming.

Lastly, thanks for sharing your code.

anythingwhat commented 6 years ago

@Libincn hi,can you speak chinese? 我在用这个app的时候遇到了两个问题: 1 查看含中文的文件,如果中文不是utf-8编码,webssh终端会connection close 2 webssh终端不能输入中文,不能切换到中文输入法 请问你碰到这两个问题了吗?

Libincn commented 6 years ago

@anythingwhat This app https://github.com/huashengdun/webssh seems support non-utf8 encoding. You may give it a try.

anythingwhat commented 6 years ago

@Libincn,thanks