search

xsawyerx / PearlBee

Blogging system in Modern Perl
6 stars 2 forks source link

Disqus #22

Closed andrewalker closed 8 years ago

andrewalker commented 8 years ago

Due to my own stupidity, I implemented this three times. First I gave it a go in our first hackathon. Then, after a bunch of cleanups, it became unmergeable. So earlier today I picked change by change, some of which were poorly done in the first place, and finished it. But I did this cherry-picking by duplicating the folder, and comparing the two branches. At the end of it, I pushed it, and deleted the folder. To my despair, my push wasn't in github :scream: And then I had to redo the whole thing again.

So... all that to say that this hasn't been tested after the third attempt :see_no_evil:

There might be some stuff that may not be the optimal Dancer-way, so please let me know if I did something horribly wrong, or if there's something that could be better, etc.

We should probably test both engines before merging, and I'd love if somebody reviewed it as well. I believe the commits are pretty clear, both in code and commit messages. But if there are any concerns, I'd be happy to disqus discuss it further here in the PR!

andrewalker commented 8 years ago

Also, the PR is against wip/new-endpoint-struct. Should it be against master? Lets merge stuff, please! We should strive to merge back to PearlBee main repo...

xsawyerx commented 8 years ago

I've merged the wip branch into master and pushed it. I'll have this rebased before merging it directly into master.

andrewalker commented 8 years ago

Sounds like a plan :)

andrewalker commented 8 years ago

Will open a new one, with the rebased branch.