search

xsawyerx / metacpan-api

A comprehensive, DWIM-featured API to MetaCPAN
http://search.metacpan.org
14 stars 14 forks source link

Fixes for Moo conversion #18

Closed haarg closed 9 years ago

haarg commented 11 years ago

This merges in the master branch, and makes a few fixes to the Moo conversion branch.

Primarily, it switches from namespace::autoclean to namespace::clean. Using namespace::autoclean will force Moose meta-objects to be inflated for everything, eliminating any real benefit from using Moo.

haarg commented 11 years ago

Actually, I was wrong about the meta-object inflation. I still think it would be better to use namespace::clean though, as it doesn't bring in the dependency on Moose.

xsawyerx commented 11 years ago

Why not namespace::sweep?

It's like namespace::autoclean without Class::MOP. :)

haarg commented 11 years ago

I personally prefer namespace::clean as it is entirely predictable, and doesn't rely on any heuristics like ::sweep. But ::sweep would also be a reasonable choice for a Moo based class.

tokuhirom commented 11 years ago

Bump? What the state of Moo work?

xsawyerx commented 11 years ago

The problem was deciding the structure.

@haarg had an entire (wonderful) plan but didn't get around it. Perhaps if we all get him a beer, he'd like to continue it...? :)

xsawyerx commented 11 years ago

Or otherwise outline the plan. I failed to remember it.

azawawi commented 11 years ago

Any update on this one?

xsawyerx commented 11 years ago

There is a rewrite design, and already a work in progress by @haarg. I hope to join him at some point, but him might still finish it before I do. He's too good, that guy. :)

tokuhirom commented 10 years ago

Bump?

xsawyerx commented 10 years ago

There is a beautiful complete rewrite of MetaCPAN::API. It's in branch 1.000 waiting for transition to use the new Elasticsearch.pm (instead of the deprecated ElasticSearch.pm).

The new version uses Moo indeed.

Once the new version is out, I will close this ticket. It should be soon, as we're now working with Clinton (in charge of Elasticsearch.pm/ElasticSearch.pm modules) on working out a possible bug in the module.

tokuhirom commented 10 years ago

Great! I'm waiting it :)