Convert from Any::Moose to Moo

xsawyerx / metacpan-api

A comprehensive, DWIM-featured API to MetaCPAN

http://search.metacpan.org

14 stars 14 forks source link

Convert from Any::Moose to Moo #27

Closed haarg closed 9 years ago

haarg commented 9 years ago

This is a refresh of #18.

I've converted it to use Types::Standard. namespace::autoclean has been updated to work well with Moo since the last PR, so there was no need to touch that part. I've also added Test::RequiresInternet to the tests to fix #25.

xsawyerx commented 9 years ago

Why not MooX::Types::MooseLike?

xsawyerx commented 9 years ago

Everything looks good except for:

Not sure why Types::Standard and not MooX::Types::MooseLike.
I don't like is => 'lazy', it's not Moose-compliant.

haarg commented 9 years ago

Type::Tiny and Types::Standard are faster, more compatible, have a better API, and have a better namespace. The Moo docs have been changed to recommend them over MooX::Types::MooseLike. They can also be used with Moose without alteration.

I've added a commit to remove the is => 'lazy'.

xsawyerx commented 9 years ago

Merged, released. Thanks! :)