search

xsawyerx / www-xkcd

Synchronous and asynchronous interfaces to xkcd comics
7 stars 2 forks source link

added fetch_random method #5

Closed ambs closed 8 years ago

ambs commented 8 years ago

Fetch randomly a comic.

xsawyerx commented 8 years ago

Any chance to make the method async-aware?

ambs commented 8 years ago

I can try. What would be the model? First async get metadata, and its callback gets image with user-callback?

ambs commented 8 years ago

Better this way? :-) also, I would remove the two firsts tests from async.t, they are duplicates from sync.t.

xsawyerx commented 8 years ago

Looks good! :+1:

ambs commented 8 years ago

Now that I removed these two tests I notice there are other test scripts doing the same. Not sure what to do. Revert to 2d1cb7e or continue pruning test files.

xsawyerx commented 8 years ago

Merged and released. Thank you. :+1:

ambs commented 8 years ago

Thank you 💃