search

xsawyerx / xs-fun

XS is fun: a simple and easy tutorial on writing Perl XS
144 stars 35 forks source link

Some documentation fixups #7

Closed paultcochrane closed 10 years ago

paultcochrane commented 10 years ago

In the process of going through the chapters, I noticed a few places where textual improvements could be made (and a couple of minor bugs). I've sliced the changes very finely, so please let me know if I should merge some of them together, or if they can be improved in some way. Some of the changes are really only recommendations for slight modifications to the textual flow, so you might not need all of the commits. Hopefully this helps out in some way!

paultcochrane commented 10 years ago

Hi @xsawyerx, are these changes acceptable/up-to-standard?

xsawyerx commented 10 years ago

Hey Paul! I'm sorry, I only now saw the notification about it. Damn GH. :/

I'll go over them tomorrow!

xsawyerx commented 10 years ago

Just reviewed them quickly. They're great. Thank you so much! :)

xsawyerx commented 10 years ago

Merged! Thanks again. :)

paultcochrane commented 10 years ago

On 23 April 2014 23:25:40 CEST, Sawyer X notifications@github.com wrote:

Just reviewed them quickly. They're great. Thank you so much! :)

Reply to this email directly or view it on GitHub: https://github.com/xsawyerx/xs-fun/pull/7#issuecomment-41216907

Cool! Thanks for the merge! Cheers, Paul