search

xsburg / vscode-javascript-booster

Sprinkle extra refactorings, code actions and commands over your JavaScript! 🍩 TypeScript and Flow are first class citizens as well!
https://marketplace.visualstudio.com/items?itemName=sburg.vscode-javascript-booster
160 stars 13 forks source link

Extend/Shrink selections fallback not working #4

Closed geoff-harper closed 6 years ago

geoff-harper commented 6 years ago

When I try to use the command I bound (Cmd + W, Cmd + Shift + W) in an unsupported file, I get a notification saying that the command is not found.

// Specifies the fallback command that should be executed if the file is not supported by smart selection.
"javascriptBooster.smartExtendFallbackCommand": "editor.action.smartSelect.grow",

// Specifies the fallback command that should be executed if the file is not supported by smart selection.
"javascriptBooster.smartShrinkFallbackCommand": "editor.action.smartSelect.shrink"

I haven't changed the keybindings of the default commands. I'm on v0.6.0 for the extension and v1.22.2 for VSCode.

xsburg commented 6 years ago

Hi @geoff-harper,

Thanks for reporting! I see what the problem is and will fix it shortly. I'll publish the new version in an day or two after I've tested all the changes pending for the release.

Cheers! 🎉