Bad performance while typing

xsburg / vscode-javascript-booster

Sprinkle extra refactorings, code actions and commands over your JavaScript! 🍩 TypeScript and Flow are first class citizens as well!

https://marketplace.visualstudio.com/items?itemName=sburg.vscode-javascript-booster

160 stars 13 forks source link

Bad performance while typing #6

Closed jrieken closed 6 years ago

jrieken commented 6 years ago

install this extension
work on vscode, open vscode.d.ts
type inside a doc comment
everything is slow 🐌
profile running extensions via the 'F1 > Show Running Extensions' and notice that this extension parses the file in process, see attached CPU-profile

CPU-20180502T092042.282Z.cpuprofile.txt

jrieken commented 6 years ago

It would be beneficial if this extension follows the guidance provided here: https://code.visualstudio.com/docs/extensions/overview#_language-servers

xsburg commented 6 years ago

Thanks for pointing this out, the problem speaks for itself. I will focus on this issue and extract the AST logic into a language server in the upcoming release.

xsburg commented 6 years ago

Hi @jrieken,

I've addressed this issue in release 0.8.0, all AST-related logic is now isolated into a language server and the overall performance seems to be much better. There are still things that could easily boost the performance of the server itself, I'm going to address it in future versions.

I suppose it is now usable for working with large files and doesn't deteriorate user experience. Thanks a lot for bringing this up and please report any problems you might come across. I really appreciate any feedback.

Cheers! 🎉