search

xsc / kithara

A Clojure Library for Reliable RabbitMQ Consumers
http://xsc.github.io/kithara/
MIT License
21 stars 6 forks source link

Unclear required dependencies #5

Closed MarketaAdamova closed 8 years ago

MarketaAdamova commented 8 years ago

Hi, I have a question about some libraries which are required for using kithara but there is no notes about this in README.

com.rabbitmq/amqp-client This is ok, I see why should be provided. But maybe a comment in README would help to clarify (also did not work with older version of amqp-client I originally had in my computer - sorry can't remember the exact version anymore).

org.slf4j/slf4j-log4j12 This is defined as dependency for dev profile but unless I import it separately, SLF4J will default to a no-operation implementation and I only get warning message.

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Again if expected to be present maybe a note should be added to README?

Thanks Marketa

xsc commented 8 years ago

@MarketaAdamova I actually never intended to not have com.rabbitmq/amqp-client included - I expected the transitive one from Lyra to be used but seems I misunderstood the provided scope and never verified that the client was really there... :-/

Regarding org.slf4j/slf4j-log4j12, I'll add a note that this library uses SLF4J-compliant logging so an actual logging dependency needs to be included. (It's not "expected to be present" per se, since kithara will work without it just as well.)

MarketaAdamova commented 8 years ago

Hi, the Lyra version you are using has this dependency.

`

com.rabbitmq amqp-client 3.5.3 provided 
<dependency>
  <groupId>org.slf4j</groupId>
  <artifactId>slf4j-api</artifactId>
  <version>1.7.5</version>
</dependency>

` It has only provided scope as well but also you need newer version for kithara code (I think :)

xsc commented 8 years ago

com.rabbitmq/amqp-client is now included directly and I added a note to the README about logging. FWIW, the kithara tests seem to pass with version 3.5.3 as well. :)

[kithara "0.1.3"]