Add a build option, to use external sqlite

xsco / libdjinterop

C++ library for access to DJ record libraries

GNU Lesser General Public License v3.0

49 stars 8 forks source link

Add a build option, to use external sqlite #109

Closed JoergAtGithub closed 1 year ago

JoergAtGithub commented 1 year ago

For packaging systems like VCPKG, Ubuntu, etc. it's common to have only a single version of each package. This is difficult with libdjinterop in case of sqlite. While the embedded version of sqlite makes standalone building of libdjinterop easy, it's the opposite for package system maintainers. Please add a CMake option to use external sqlite.

mr-smidge commented 1 year ago

Does -DSYSTEM_SQLITE=ON not do what you want? https://github.com/xsco/libdjinterop/blob/main/CMakeLists.txt#L38

JoergAtGithub commented 1 year ago

Oh indeed - totally overlooked this! Sorry for the noise!

mr-smidge commented 1 year ago

Happy to help! :grin: