xsdk-project / xsdk-issues

A repository under which GitHub issues not related to a specific xSDK repo can be filed.
7 stars 0 forks source link

Trilinos build failure on Frontier with +rocm #241

Open balos1 opened 11 months ago

balos1 commented 11 months ago

The spack output file is too big for github, so here it is on Google drive spack-build-out.txt

balos1 commented 11 months ago

It seems issue is related to the Ifpack interface to Hypre

n file included from /tmp/balos1/spack-stage/spack-stage-trilinos-14.4.0-l5k3rhfwmx4poriyak2aevhkbk626x7r/spack-build-l5k3rhf/packages/stokhos/src/Ifpack2_Hypre_MP_Vector_16_Serial.cpp:51:
/tmp/balos1/spack-stage/spack-stage-trilinos-14.4.0-l5k3rhfwmx4poriyak2aevhkbk626x7r/spack-src/packages/ifpack2/src/Ifpack2_Hypre_def.hpp:480:19: error: no matching function for call to 'HYPRE_IJVectorSetValues'
  IFPACK2_CHK_ERR(HYPRE_IJVectorSetValues(xHypre_,NumEntries,indices,xPtr));
                  ^~~~~~~~~~~~~~~~~~~~~~~
/tmp/balos1/spack-stage/spack-stage-trilinos-14.4.0-l5k3rhfwmx4poriyak2aevhkbk626x7r/spack-build-l5k3rhf/packages/stokhos/src/Ifpack2_Hypre_MP_Vector_16_Serial.cpp:55:44: note: in instantiation of member function 'Ifpack2::Hypre<Tpetra::RowMatrix<Sacado::MP::Vector<Stokhos::StaticFixedStorage<int, double, 16, Kokkos::Serial>>, int, int, Tpetra::KokkosCompat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace>>>::SetCoordinates' requested here
INSTANTIATE_TPETRA_MP_VECTOR_WRAPPER_NODES(IFPACK2_HYPRE_INSTANT)
jwillenbring commented 11 months ago

@cgcgcg Here is an issue on Frontier.

cgcgcg commented 11 months ago

@balos1 Do you still have the build directory? Can you get us the file packages/ifpack2/Ifpack2_HypreParameterMap.hpp that gets generated during CMake configure?

balos1 commented 11 months ago

@cgcgcg

Attached.

Ifpack2_HypreParameterMap.hpp.txt

cgcgcg commented 11 months ago

Ah shoot, this isn't one of the automatically wrapped Hypre functions. I think what's happening here is that Stokhos is enabled but Hypre cannot support AD types. So we'd need some logic in Ifpack2 that disables the Hypre adapter.

balay commented 11 months ago

Looks like a duplicate of https://github.com/xsdk-project/xsdk-issues/issues/238

cgcgcg commented 11 months ago

Unfortunately it is not. I'm working on a fix.

cgcgcg commented 10 months ago

Should be fixed by https://github.com/trilinos/Trilinos/pull/12518