search

xsdk-project / xsdk-issues

A repository under which GitHub issues not related to a specific xSDK repo can be filed.
7 stars 0 forks source link

dealii@develop build failure due to dependency on taskflow #251

Closed balay closed 8 months ago

balay commented 8 months ago

https://gitlab.com/xsdk-project/spack-xsdk/-/jobs/5541203709

  >> 187    /data/xsdkci/VS1mJQ1K/1/xsdk-project/spack-xsdk/spack-stage/balay/s
            pack-stage-taskflow-2.7.0-2iftndqyno6k3tjhb4riltpisx6qo4ar/spack-sr
            c/3rd-party/doctest/doctest.h:4032:47: error: size of array 'altSta
            ckMem' is not an integral constant-expression
     188     4032 |         static char             altStackMem[4 * SIGSTKSZ];
     189          |                                               ^
     190    compilation terminated due to -Wfatal-errors.

Looks like this is a new dependency on taskflow from dealii.

For now switching CI to dealii~taskflow

balay commented 8 months ago

https://github.com/spack/spack/pull/41098

masterleinad commented 8 months ago

https://github.com/spack/spack/pull/41095

balay commented 8 months ago

I guess both changes are needed. I noticed your PR after I created mine

Perhaps they should all be in a single PR? [you can pick up the change from mine - if that makes sense]

balay commented 8 months ago

A new issue:

https://gitlab.com/xsdk-project/spack-xsdk/-/jobs/5572273891

 4044    ../lib/libdeal_II.so.9.6.0-pre: error: undefined reference to 'Teu
             chos::RCP<Tpetra::Vector<double, int, int, Kokkos::Compat::KokkosD
             eviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> > > dealii::Ut
             ilities::Trilinos::internal::make_rcp<Tpetra::Vector<double, int, 
             int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokko
             s::HostSpace> >, Tpetra::Vector<double, int, int, Kokkos::Compat::
             KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> > const
             &, Teuchos::DataAccess>(Tpetra::Vector<double, int, int, Kokkos::C
             ompat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> 
             > const&, Teuchos::DataAccess&&)'
masterleinad commented 8 months ago

Fixed in https://github.com/dealii/dealii/pull/16278.

balay commented 8 months ago

Thanks! The build is good now.

https://gitlab.com/xsdk-project/spack-xsdk/-/jobs/5579453690