search

xseignard / thermalPrinter

Use node.js to communicate with Adafruit/Sparkfun Thermal Printer
104 stars 32 forks source link

Call print() without having to pass a callback function. #19

Closed drskullster closed 8 years ago

drskullster commented 8 years ago

I simply added a check to see if argument callback exists before calling it.

xseignard commented 8 years ago

Hello @drskullster !

Thanks for the PR! I noticed I don't even pass the err in the callback, would you mind to add it too?

Something like if (callback) callback(err);

Thanks again, I hope you find this lib useful.

Regards,

Xavier

drskullster commented 8 years ago

Completely missed that ! I added err in the last commit :)

Thanks to you !

xseignard commented 8 years ago

Thanks!