search

xshazwar / mountains-beyond-mountains

MIT License
20 stars 6 forks source link

[bug] microsplat procedural also required #if __MICROSPLAT__ #10

Closed twobob closed 2 years ago

twobob commented 2 years ago

Describe the bug installing microsplat gives Assets\billboards\MicroSplatPlugin\Integration\MSProceduralRules.cs(13,16): error CS0246: The type or namespace name 'MicroSplatProceduralTextureConfig' could not be found (are you missing a using directive or an assembly reference?)

To Reproduce Steps to reproduce the behavior: Add microsplat plugin

Expected behavior compile

forgot to post this before

twobob commented 2 years ago

image

xshazwar commented 2 years ago

Thanks for the report! MicroSplatProceduralTextureConfig is a Microsplat class (in the procedural module). I bet we need a different #if for that module instead of #IF __MICROSPLAT__. I'll take a look.

Take a look at the WIP GH-9. Among other things I've split things into separate asmdef libraries to try and solve this dependency issue with external libraries. The setup is quite different than the mainline though so I need to get some doc together (and a sample) before I merge it. Hopefully this weekend.

twobob commented 2 years ago

yeah. The procedural module maybe I dont have? don't recall having that if its an "extra"

xshazwar commented 2 years ago

Addressed in #9