search

xslate / p5-Text-Xslate

Scalable template engine for Perl5
https://metacpan.org/release/Text-Xslate
Other
121 stars 47 forks source link

Fix issue130 #143

Closed syohex closed 9 years ago

syohex commented 9 years ago

Text::Xslate::load_file returns value and it is pushed on stack. But tx_invoke_load_file function does not pop stack(and never use it), then stack pointer is incorrect after calling tx_invoke_load_file.

This patch sets G_DISCARD flag to call_method(Text::Xslate::load_file) for getting rid of return value from stack automatically.

I confirmed test1, test2 are passed with this change.

Please review this patch. This is related to #130.

syohex commented 9 years ago

Tests are passed with multiple Perl versions and both issue of #130 is resolved. Can I merge this change and release new version ?

tokuhirom commented 9 years ago

ｌｇｔｍ

gfx commented 9 years ago

LGTM!

syohex commented 9 years ago

Thanks for reviewing. I will release new version.