search

xslate / p5-Text-Xslate

Scalable template engine for Perl5
https://metacpan.org/release/Text-Xslate
Other
121 stars 47 forks source link

Ensure that test cleans up after itself. #190

Closed jkeenan closed 6 years ago

jkeenan commented 6 years ago

Test was leaving data in ~/.xslate_cache. Tests should use tempdirs rather than leaving data under tester's home directory.

Follow-up to last comment in https://github.com/xslate/p5-Text-Xslate/pull/189

skaji commented 6 years ago

thanks. It seems that tests still leave data in ~/.xslate_cache. https://gist.github.com/skaji/84e0c453ca860bd2aaf305d4a32dcfff

jkeenan commented 6 years ago

Please see updated pull request, with changes in 7 files.

This took several hours to debug. Part of the problem is that the files being written in the cache had the same names from one test file to another. That meant that it was difficult to deduce the name of the test file which needed correction from either the name or the content of the cached file.

skaji commented 6 years ago

please also check t/900_bugs/048_issue172.t

jkeenan commented 6 years ago

On 12/20/2017 10:57 AM, Shoichi Kaji wrote:

please also check t/900_bugs/048_issue172.t

Hey, I have to leave something for the maintainer to do! ;-)

But seriously, I'm not running that test because Data::Section::Simple is listed as optional and the test is skipped on my system. I'm skipping 5 of the xt/ tests as well. By now you should be able to figure out from my pull request how to handle any remaining cases of writing test data under the user's home directory.

Thank you very much. Jim Keenan

skaji commented 6 years ago

@jkeenan Thanks. Released https://metacpan.org/release/SKAJI/Text-Xslate-v3.5.5