search

xslidi / CATMO

[IMAGE24] Contrastive learning for deep tone mapping operator
MIT License
0 stars 0 forks source link

exposure_split function is missing from base_dataset.py #1

Open Liampour opened 2 days ago

Liampour commented 2 days ago

Hello, congratulation for your awesome work. When I am trying to run the test.py file an error is appearing in single_dataset.py

from data.base_dataset import BaseDataset, get_transform, get_norm, adjust2test, _resize, exposure_split, imread, _luminance

cannot import name 'exposure_split' from 'data.base_dataset'

When I looked for exposure_split in base_dataset.py I discovered that it is missing

Thank you for your time and effort

xslidi commented 2 days ago

Hello, congratulation for your awesome work. When I am trying to run the test.py file an error is appearing in single_dataset.py

from data.base_dataset import BaseDataset, get_transform, get_norm, adjust2test, _resize, exposure_split, imread, _luminance

cannot import name 'exposure_split' from 'data.base_dataset'

When I looked for exposure_split in base_dataset.py I discovered that it is missing

Thank you for your time and effort

exposure_split is an deprecated function and I forget to remove it. I have updated the new file to solve this.

Liampour commented 2 days ago

Thank you for your quick reply. Another error occurred. In test_model.py line 38.

AttributeError: 'Namespace' object has no attribute 'attention'

It seems that we have 12 input to networks.define_G( ) while the function in file networks.py requires 11.

I also created some folders in data data/HDR/testA and I added two .jpg files for the test. Is it correct ?

xslidi commented 2 days ago

It seems I forgot to clean the test code. The attention attribute and exposure are both deprecated. The code has been revised. testA folder should have HDR images, I assume the .jpg is still an LDR image?

Liampour commented 2 days ago

Thank you for your help, another error appeared in base_model.py line 135.

No such file or directory: './checkpoints\CATMO\latest_net_G.pth'

the latest_net_G.pth doesn't seem to be uploaded

Yes the .jpg is an LDR image. I have now noticed that in the description you mentioned that testA folder should contain an HDR input. In which folder should I paste the LDR image? The HDR image in the testA folder should be the final result of the inputted LDR?