xsrf / easyeda-svg-import

Simple SVG Importer for EasyEDA PCB that doesn't convert everything to Comic Sans 😄
85 stars 8 forks source link

Import Issues #12

Closed OpenSourceModular closed 3 years ago

OpenSourceModular commented 3 years ago

I don't know if this is an issue or expected behavior, but I thought I would post it anyways. I am using inkscape 1.0.1

If I create a filled box, circle, hex, and then convert to paths they import as intended. If I create the same object, but remove the fill and add the outline, they still import as filled. If I draw a path with a bezier tool, i.e. a curved line, it imports it as filled. If I draw a horizontal or vertical path, it does not import it at all.

(All items selected in Inkscape and converted to paths before saving).

Thanks!

Screenshot from 2021-03-11 13-41-59 Screenshot from 2021-03-11 13-41-29

xsrf commented 3 years ago

Hey, at first glance this is expected. Imports as SVG nodes or solid regions are always closed filled shapes defined by the paths / outlines. This is why the curved line gets closed and the two straight lines probably got imported but are not visible (zero width). If you import as Track instead, only the outlines will be imported as tracks. This will import the curved line and the straight lines correctly and imports the top shapes without fill. There may be a way to convert the actual outlines of objects into paths, so that all shapes directly import as you expect. I'll have a look at that. I'm not really an expert with Inkscape.

OpenSourceModular commented 3 years ago

I see - that makes sense. No need for you to look into inkscape. I can come up with a workflow that suits my needs.

Thanks!

xsrf commented 3 years ago

Okay, confirmed. You may use Stroke to Path on all shapes except the first three to get the result you probably expected. Basically, while shapes in Inkscape do have fill and stroke, in EasyEDA they are either fill (SVG Node, solid region) or stroke (Track). Hope that helps! I may add some of the examples you provided to the readme.

OpenSourceModular commented 3 years ago

Yes, I just experimented and found the same result - thanks!

xsrf commented 3 years ago

I've added some example screenshots to the readme: