Added serialization support for some types, added way to get original tx bytes

xssnick / tonutils-go

TON SDK Library in pure Golang for interacting with The Open Network ecosystem using native protocols, such as ADNL, RLDP and etc.

Apache License 2.0

464 stars 95 forks source link

Added serialization support for some types, added way to get original tx bytes #172

Closed Stanislav-Povolotsky closed 4 months ago

Stanislav-Povolotsky commented 5 months ago

Added ToCell serialization support for tlb.Transaction, tlb.Message, tlb.ExternalMessageOut
Added APIClient.GetTransactionEx method, which is useful when you need original unmodified transaction bytes

xssnick commented 5 months ago

Hi, thank you for PR!

But ToCell serialization of Message type is already implemented in dev-19 branch (v1.9 will be released soon).

And for the *Ex methods I think they are for too specific use cases, and it is better to just call api.Client().QueryLiteserver(ctx, GetBlockData{ID: block}, &resp) in your project's code to get such data, to not overcomplicate library.

Stanislav-Povolotsky commented 5 months ago

Hello Oleg, Sounds great! Thank you for you work! You are right. I will implement *Ex functions in my own code, but, I'll have to duplicate proof-check-logic in my code (for example: I will have to copy whole APIClient.GetTransaction function to later be able to check the proof of the saved TransactionInfo cell. It would be great if the library could provide the ability to check the proof for such cells with additional functions (cell deserialization with the proof-checking). But I understand that this will also overcomplicate the library, which may be undesirable)