search

xsuchy / rpmconf

Tool to handle rpmnew and rpmsave files
44 stars 19 forks source link

rpmconf test failures with python 3.5+pylint+python-astroid 1.4.1 #31

Closed Conan-Kudo closed 7 years ago

Conan-Kudo commented 8 years ago

While building rpmconf 1.0.16-1 for Mageia Cauldron (upcoming Mageia 6), I got the following output from building the package on Cauldron (Python 3.5, python-astroid 1.4.1):

Executing(%check): /bin/sh -e /home/ngompa/rpmbuild/tmp/rpm-tmp.LG1IVZ
+ umask 022
+ cd /home/ngompa/rpmbuild/BUILD
+ cd rpmconf-rpmconf-1.0.16-1
+ '[' 1 -eq 1 ']'
+ python3-pylint --reports=n /home/ngompa/rpmbuild/BUILDROOT/rpmconf-1.0.16-1.mga6.x86_64/usr/sbin/rpmconf
Warning: option profile is obsolete and it is slated for removal in Pylint 1.6.
Warning: option include-ids is obsolete and it is slated for removal in Pylint 1.6.
Warning: option symbols is obsolete and it is slated for removal in Pylint 1.6.
Warning: option comment is obsolete and it is slated for removal in Pylint 1.6.
Warning: option ignore-iface-methods is obsolete and it is slated for removal in Pylint 1.6.
Warning: option required-attributes is obsolete and it is slated for removal in Pylint 1.6.
Warning: option zope is obsolete and it is slated for removal in Pylint 1.6.
************* Module rpmconf
C: 22, 0: standard import "import errno" comes before "from rpmconf import rpmconf" (wrong-import-order)
C: 23, 0: standard import "import os" comes before "from rpmconf import rpmconf" (wrong-import-order)
C: 24, 0: standard import "import sys" comes before "from rpmconf import rpmconf" (wrong-import-order)
C: 25, 0: standard import "import time" comes before "from rpmconf import rpmconf" (wrong-import-order)
error: Bad exit status from /home/ngompa/rpmbuild/tmp/rpm-tmp.LG1IVZ (%check)
Conan-Kudo commented 8 years ago

After fixing the import order in bin/rpmconf, I got these issues:

Executing(%check): /bin/sh -e /home/ngompa/rpmbuild/tmp/rpm-tmp.3LvrSY
+ umask 022
+ cd /home/ngompa/rpmbuild/BUILD
+ cd rpmconf-rpmconf-1.0.16-1
+ '[' 1 -eq 1 ']'
+ python3-pylint --reports=n /home/ngompa/rpmbuild/BUILDROOT/rpmconf-1.0.16-1.mga6.x86_64/usr/sbin/rpmconf
Warning: option profile is obsolete and it is slated for removal in Pylint 1.6.
Warning: option include-ids is obsolete and it is slated for removal in Pylint 1.6.
Warning: option symbols is obsolete and it is slated for removal in Pylint 1.6.
Warning: option comment is obsolete and it is slated for removal in Pylint 1.6.
Warning: option ignore-iface-methods is obsolete and it is slated for removal in Pylint 1.6.
Warning: option required-attributes is obsolete and it is slated for removal in Pylint 1.6.
Warning: option zope is obsolete and it is slated for removal in Pylint 1.6.
+ python3-pylint --reports=n /home/ngompa/rpmbuild/BUILDROOT/rpmconf-1.0.16-1.mga6.x86_64/usr/lib/python3.5/site-packages/rpmconf/rpmconf.py
Warning: option profile is obsolete and it is slated for removal in Pylint 1.6.
Warning: option include-ids is obsolete and it is slated for removal in Pylint 1.6.
Warning: option symbols is obsolete and it is slated for removal in Pylint 1.6.
Warning: option comment is obsolete and it is slated for removal in Pylint 1.6.
Warning: option ignore-iface-methods is obsolete and it is slated for removal in Pylint 1.6.
Warning: option required-attributes is obsolete and it is slated for removal in Pylint 1.6.
Warning: option zope is obsolete and it is slated for removal in Pylint 1.6.
************* Module rpmconf.rpmconf
I:  4, 0: Locally disabling missing-docstring (C0111) (locally-disabled)
I:  4, 0: Locally disabling too-many-arguments (R0913) (locally-disabled)
I:  4, 0: Locally disabling too-many-branches (R0912) (locally-disabled)
I: 73, 0: Locally disabling no-member (E1101) (locally-disabled)
I: 77, 0: Locally disabling no-member (E1101) (locally-disabled)
I:127, 0: Locally disabling no-member (E1101) (locally-disabled)
I:130, 0: Locally disabling no-member (E1101) (locally-disabled)
I:182, 0: Locally disabling no-member (E1101) (locally-disabled)
I:399, 0: Locally disabling no-member (E1101) (locally-disabled)
W:115,15: Used builtin function 'input' (bad-builtin)
R:176,12: Redefinition of diff type from generator to bytes (redefined-variable-type)
error: Bad exit status from /home/ngompa/rpmbuild/tmp/rpm-tmp.3LvrSY (%check)
xsuchy commented 8 years ago

First one fixed in 5bcadea. For the second I will welcome the patch as I do not have the new pylint to reproduce.

Conan-Kudo commented 8 years ago

@xsuchy You should be able to reproduce it in Fedora rawhide, as it has the same versions as Mageia Cauldron.

xsuchy commented 7 years ago

Should be resolved now.