search

xsuchy / rpmconf

Tool to handle rpmnew and rpmsave files
44 stars 19 forks source link

Remove deprecated no-op setInterruptSafety() call #52

Closed dmnks closed 1 year ago

dmnks commented 1 year ago

This function no longer has any effect in RPM since the removal of the Berkeley DB backend in RPM 4.16. The Python binding has been deprecated for a while now, and is completely gone in RPM 4.19, so let's move with the times.

More info here:

https://github.com/rpm-software-management/rpm/pull/1946 https://github.com/rpm-software-management/rpm/pull/1992 https://github.com/rpm-software-management/rpm/pull/1994

xsuchy commented 1 year ago

This will not be easy. It was added as a fix for 66b896e2e4b58e49737a71bd46e7837f154ebb15 to solve https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=1236722 I am on holiday now, will check this after a week.

dmnks commented 1 year ago

OK, now I realize this PR was a bit rushed on my side, I somehow mixed up the chronology of the commits linked above and thought the Python binding had been no-op for a long time. Whereas, it really was only deprecated and made no-op in 4.18 which came out last year. :facepalm: Apologies for that.

That said, the functionality itself might indeed be redundant now that we no longer use BDB, but depending on your release model, you may want to keep the code compatible with older RPM versions, too. In that case, we could perhaps apply this patch downstream only (in Rawhide).

Anyway, let's revisit when you're back.

dmnks commented 1 year ago

I've updated the PR with a backward compatible version of the same, hopefully this is now better.

Whether or not there's a regression in terms of 66b896e2e4b58e49737a71bd46e7837f154ebb15 with RPM 4.18 I'm not sure but if so, that has to be fixed separately. This PR is just to make rpmconf work with RPM 4.19 the same way as it did with 4.18. IOW, to adapt rpmconf to the deprecation in 4.18.

xsuchy commented 1 year ago

Closing in favour of https://github.com/xsuchy/rpmconf/pull/53