Closed giadarol closed 8 months ago
I just saw the test not passing because of the import of xtrack. That can be avoided. I'll update the PR
Just updated. I also commented out the alterations to the matplotlib rcParams
, as this changes the aspect of all other plots within the same session, which I find a bit invasive :-)
I just saw the test not passing because of the import of xtrack. That can be avoided. I'll update the PR
Hi @giadarol and many thanks for adding support for thick elements here!
I made a few more adjustments to handle line==None
properly in case of having a quick look at MAD-X survey (without the nice wedges of course). Does this work for you?
Just updated. I also commented out the alterations to the matplotlib
rcParams
, as this changes the aspect of all other plots within the same session, which I find a bit invasive :-)
I agree that this is invasive, however instead of uncommenting that, it should go into a matplotlib style sheet, so it can be called by the user manually (I would still like to use these "good defaults" in my Jupyter notebooks with a single line):
xplt.apply_style()
PS: I would like to show these features for the Xsuite tutorial at the Slow Extraction Workshop. What do you think?
It would be an honour :)
I just saw the test not passing because of the import of xtrack. That can be avoided. I'll update the PR
Hi @giadarol and many thanks for adding support for thick elements here! I made a few more adjustments to handle
line==None
properly in case of having a quick look at MAD-X survey (without the nice wedges of course). Does this work for you?
yes!
PS: I would like to show these features for the Xsuite tutorial at the Slow Extraction Workshop. What do you think?
It would be an honour :)
Thank you! Would you manage to make also a PyPI release by then? So that people will be able to run the example notebooks that I will show after a simple pip install of the packages
Yes, I can make a release in the next days.
@giadarol I pushed a new version, CI is running and it should soon appear on PyPI.
However, I noticed that there seems to be an issue in XZ-projection (projection="XZ"
): for thick elements, the wedge is slightly displaced. In the default ZX-projection it works though.
xt.Multipole | xt.Bend |
---|---|
This PR adds:
FloorPlot
.Here a small example (using a lattice available in the xtrack test data):
PS: I would like to show these features for the Xsuite tutorial at the Slow Extraction Workshop. What do you think?
My contribution follows "inbound=outbound" licensing as defined by the GitHub Terms of Service.