xsun2001 / Applied-Energistics-2-Unofficial

Unofficial AE2 for 1.7.10 which is still supported,which is like the extraterrestrial technology.
Other
28 stars 13 forks source link

Duplication bug :D #2

Closed runescapejon closed 7 years ago

runescapejon commented 7 years ago

Hey thanks for keep supporting 1.7.10,

anyways there this 1 duplication bug found here how to do it

GIF

xsun2001 commented 7 years ago

Thanks for the report. But I think it is not the issue of ae2. EnderIO's conduit may transport items unsynchronized. Please use other conduit to test. I will try to find the cause of this problem. Sorry for my poor English.

runescapejon commented 7 years ago

your english is good don't worry but i will test more conduit but for more information, you don't really need item buffer you can do this with a different items that can store stuff example have 2 chest, it just so happen to be item conduits because transport item but from what i understand you can do this with any pipes that can suck out from a chest and transport them to another. but will do more testing

runescapejon commented 7 years ago

it works with any container (strongbox, chest, etc) you just need! item conduits, so i guess you right is it fixable tho ?

xsun2001 commented 7 years ago

I will try to find the cause in AE2. But I find if you use a BC wooden pipe, it will work fine. And I think chest will not work, because the items in the chest will enter the ME Network, or I misunderstand you?

runescapejon commented 7 years ago

Opps my bad i meant to say Strongbox chest it's from Thermal Expansion mod and only item conduits works i had already tried wooden pipe it does not dupe

xsun2001 commented 7 years ago

We still need to make sure that this issue is our bug or not. BC's pipe is good but EnderIO's pipe is bad. We need to find more pipes that may reproduce this issue. I don't have too much time to find them because I am studying in a Chinese Senior High. So trouble you to help me find them. If this bug is confirmed to be my problem, I will do my best to fix it.

runescapejon commented 7 years ago

okay i have tried all the pipes from different's mods and i can only reduce this problem with Enderio pipes (Item conduits)

Eufranio commented 7 years ago
BC's pipe is good but EnderIO's pipe is bad

AE2 is bad by not firing a block break event on the anihillation plane break (that is respected by EnderIO), both parts are wrong here. You can fix it by the AE2 side by introducing a break event.

EverNife commented 7 years ago

Else it would help "region protection" plugins, like Grief Prevention :D

Eufranio commented 7 years ago

No, it would not since there is no need to use fake players in that case.

xsun2001 commented 7 years ago

I try to post a BlockEvent.BreakEvent when the annihilation plane breaks a block, but it seems not work. I don't know a lot about the EnderIO's conduit. I think I should to read its code...

Eufranio commented 7 years ago

Probably. I tested in dev and realized that the conduits will "reload" the network and repeat the checks if a break event is fired. Not firing them will make the conduit not reload and just extract. Maybe other thing in the AE2 code...

xsun2001 commented 7 years ago

I am terrible sorry but I cannot fix this bug. Due to EnderIO doesn't use 'onNeighborChanged' to update its item conduit in its 1.7.10 version. So I think I cannot fix this bug in AE2's controlled area. But EnderIO is discontinued to maintain too..... I am sorry for your 2-mouth waiting but to receive a bad result.

Eufranio commented 7 years ago

The dev said it uses, doesn't it?

Eufranio commented 7 years ago

@xsun2001?

xsun2001 commented 7 years ago

@Eufranio No,they don't do that in 1.7.10. 9k 0fl g8p7cvn y6 c9jn left is master branch which is for mc1.7.10 and right is 1.10 branch.

EverNife commented 7 years ago

Lets recompile them too :v:

Eufranio commented 7 years ago

What do you think about using Mixin to add the event yourself/refresh the network when EnderIO is present? If the dev approves, ofc.

xsun2001 commented 7 years ago

It may be a good method. If add the onNeighborChanged method to ItemConduit can really solve this problem, I will try it.

Eufranio commented 7 years ago

Hope you can, but let the EnderIO dev know you're ASMing his mod first :P