search

xtaci / kcp-go

A Crypto-Secure Reliable-UDP Library for golang with FEC
MIT License
4.12k stars 737 forks source link

Use of deprecated crypto libraries #256

Closed faddat closed 10 months ago

faddat commented 10 months ago

kcp-go currently uses a number of deprecated crypto libraries, including some that have been broken.

This issue is solved in #254 but that may make sense to break into its own PR. I also wanted to know if there's an intentional reason that they were being used.

xtaci commented 10 months ago

they're not broken, these crypto algos were included on purpose.

faddat commented 10 months ago

Thank you very much 🙂

I'll pull those changes out of my PR in that case. Some of them do report as broken but I think I understand what you mean about their being included on purpose.

They do however show big big huge deprecation warnings and... what are your thoughts on that?

I'm thinking about this from the perspective of a downstream integrator and basically what's going to happen is when KCP-go is imported, downstream users are likely to get all kinds of warnings in their own ci systems about the libraries kcp uses.

Thanks so much for your work here over several years.

I have built a number of prototypes using kcp-go and really enjoy it.