search

xtaci / smux

A Stream Multiplexing Library for golang with least memory usage(TDMA)
MIT License
1.27k stars 189 forks source link

Close session when seeing any session level errors #62

Closed joesis closed 4 years ago

joesis commented 4 years ago

So the caller can notice it when opening new streams or via the GetDieCh, then have the opportunity to dial new sessions, or the session can enter into a weird state, see https://github.com/xtaci/smux/issues/61

joesis commented 4 years ago

This is for https://github.com/getlantern/lantern-internal/issues/3247

codecov-io commented 4 years ago

Codecov Report

Merging #62 into master will increase coverage by 3.69%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   80.25%   83.94%   +3.69%     
==========================================
  Files           6        6              
  Lines         780      704      -76     
==========================================
- Hits          626      591      -35     
+ Misses        131       93      -38     
+ Partials       23       20       -3
Impacted Files Coverage Δ
session.go 80% <100%> (+6.43%) :arrow_up:
mux.go 90% <0%> (ø) :arrow_up:
stream.go 84.96% <0%> (+0.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 211bc4a...f335492. Read the comment docs.

joesis commented 4 years ago

Sorry, open in the wrong repo