search

xtendo-org / chips

A fast, lightweight, and concurrent plugin manager for the fish shell, written in Haskell
73 stars 3 forks source link

Doesn't work on Sierra #20

Closed sargunv closed 7 years ago

sargunv commented 7 years ago

I get the following error when trying to run chips on the macOS Sierra public beta:

fish: 'chips' terminated by signal SIGKILL (Forced quit)
xtendo-org commented 7 years ago

Thanks for the report!

@simnalamburt Do you think you can reproduce this?

simnalamburt commented 7 years ago

I do not have any spare machine to install macOS Sierra. Help wanted

sargunv commented 7 years ago

I've never worked with Haskell, but I could try to take a look myself.

On Sat, Jul 30, 2016, 3:17 AM Hyeon Kim notifications@github.com wrote:

I do not have any spare machine to install macOS Sierra. Help wanted

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kinoru/chips/issues/20#issuecomment-236350168, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQlpZutm992fZI4kis_BK8-Bjdwf8G-ks5qavqlgaJpZM4JThpG .

sargunv commented 7 years ago

Having trouble installing Stack via Brew on Sierra. Guess it'll have to wait for Brew or Stack to update to support Sierra.

https://github.com/Homebrew/homebrew-core/issues/1957

simnalamburt commented 7 years ago

Looks like El Capitan binary is incompatible with Sierra.

xtendo-org commented 7 years ago

Oh, that explains it. 😃

I'm a full-time GNU/Linux user, but a lot of Haskellers (including the people who make and maintain the Haskell tool chain) definitely use OS X, so I'm sure the switch to macOS will happen pretty quickly once it releases officially.

Until that happens, let's leave this issue open, shall we? 😄 We might soon need to serve three different executable binaries, I guess.

xtendo-org commented 7 years ago

Hmm.

It seems the binary compatibility should not be the issue? @heejongahn built a macOS Sierra binary, and @simnalamburt confirmed that it works on OS X El Capitan.

xtendo-org commented 7 years ago

@sargunster The new 1.1.0 release should work on Sierra as well. Could you give it a try?

sargunv commented 7 years ago

Still getting the error after installing the new version:

fish: 'chips' terminated by signal SIGKILL (Forced quit)
simnalamburt commented 7 years ago

@heejongahn and I could not reproduce that error on our macOS machine. Are you still using Sierra public beta or did you upgraded it with official Sierra release?

sargunv commented 7 years ago

I'm using the official release.

On Mon, Oct 3, 2016, 11:48 AM Hyeon Kim notifications@github.com wrote:

@heejongahn https://github.com/heejongahn and I could not reproduce that error on our macOS machine. Are you still using Sierra public beta or did you upgraded it with official Sierra release?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xtendo-org/chips/issues/20#issuecomment-251143457, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQlpXT8PfW9_ld3xrExS_m1pYw_uI7Oks5qwSO3gaJpZM4JThpG .

xtendo-org commented 7 years ago

@sargunster Can you try building 1.1.0 from source with the latest Stack?

sargunv commented 7 years ago

Building from source works fine. There's a large file size difference between the two binaries:

~/.l/bin> ls -l
total 77072
-rwxr-xr-x  1 sargunvohra  staff  35527216 Oct  4 10:00 chips_built
-rwxr-xr-x  1 sargunvohra  staff   3932160 Oct  2 08:14 chips_downloaded
simnalamburt commented 7 years ago

That's correct. We compress chips binaries with upx

xtendo-org commented 7 years ago

The file size difference is probably due to strip and upx applied for the release binary.

At this point, we don't have enough cases; it could be something that is wrong in both @heejongahn and @simnalamburt's machine, or it could be just @sargunster. Maybe we can detect the root cause by disassembling and analyzing the two binaries, it's a shame I have neither the knowledge nor the tool for that...

Hopefully a plan I already have can address this; As I don't own a macOS machine, releasing chips so far required me asking someone else with an OS X or macOS machine to manually build from source and hand me the binary. This is why I am going to set up a CircleCI-based automatic build for macOS before the next release.

If that build works okay on any macOS machine, everyone can be happy. Until that happens, I apologize for the inconvenience that you have to build from source.

nyeong commented 7 years ago

I'm using chips, building from source manually, on macOS Sierra(10.12.1). Maybe the issue have been solved.

macowie commented 7 years ago

I was also able to build from source and use it just fine, on two machines now, one with 10.12.2 and one on 10.12.1.

simnalamburt commented 7 years ago

Chips 1.1.1 has been released. Now chips should work fine on macOS Sierra.

simnalamburt commented 7 years ago

Sierra support of chips 1.1.1 and 1.1.2 have been widely tested. I'm closing this issue now. Please mention me if there's any further problem. Thanks! :shipit: