search

xtendo-org / chips

A fast, lightweight, and concurrent plugin manager for the fish shell, written in Haskell
73 stars 3 forks source link

Remove resolver overriding #22

Closed heejongahn closed 8 years ago

heejongahn commented 8 years ago

For now, travis build fails due to with the message like:

While constructing the build plan, the following exceptions were encountered:
In the dependencies for chips-1.0.0:
    aeson-1.0.1.0 must match >=0.11.1.4 && <0.12 (latest applicable is 0.11.2.1)
Plan construction failed.
The command "stack --no-terminal --install-ghc $ARGS test --only-dependencies" failed and exited with 1 during .

This is due to resolver(snapshot?) overriding caused by --resolver nightly option in .travis.yml. So I just deleted that part and now build works just fine. Still, I'm not sure whether this deletion might cause undesired side effects or not so please check if there's any.

simnalamburt commented 8 years ago

We need to know the history of this repo. As far as I remember, --resolver nightly flag was added intentionally.

Does aeson 1.0 still requires nightly resolver? Maybe it'd be better if we just solve this problem with updating dependencies.

heejongahn commented 8 years ago

Yes, aeson 1.0 requires nightly resolver. The latest LTS supports 0.11.2.1 (I'm not sure about the point of the question, though)

On my second thought, I also think that updating dependency would be a more appropriate way to solving this issue. However, if we do so, from time to time CI will break without changing anything, because of stackage snapshot update. Is this desired behavior?

xtendo-org commented 8 years ago

To tell you the truth: The Travis build is broken anyway, and I plan to completely move to CircleCI.

heejongahn commented 8 years ago

Well, in that case, this PR is irrelevant so I'll just close it. I have no experience in CircleCI but would you mind if I try setting it up for chips?