search

xtendo-org / chips

A fast, lightweight, and concurrent plugin manager for the fish shell, written in Haskell
73 stars 3 forks source link

Chips lost '+x' permission after being auto-upgraded #23

Closed simnalamburt closed 7 years ago

simnalamburt commented 7 years ago

How to reproduce this error

image

How to fix it

https://github.com/xtendo-org/chips/blob/master/src/SelfUpdate.hs#L67

runUpdate repo tag assetName path = getAsset >>= \case
    Right bin -> bracket topen hClose $ \ h -> do
        B.hPut h bin
        hClose h
        rename tmpPath path
        return $ Right tag
    Left err -> return $ Left err

Maybe we should call chmod +x path thing after rename tmpPath path

xtendo-org commented 7 years ago

Fixed in 36ca3dc

Thanks for reporting!