search

xtensor-stack / xtensor-benchmark

Easy to use benchmarks for linear algebra frameworks
BSD 3-Clause "New" or "Revised" License
24 stars 8 forks source link

Adding more benchmarks, generalized usage. #10

Closed emmenlau closed 5 years ago

emmenlau commented 5 years ago

This PR adds a number of additional benchmarks, and slightly generalizes the usage. A new option BENCHMARK_XTENSOR allows to enable or disable xtensor in the benchmarks. This is mostly useful during implementation when not all benchmarks are required. The setting of -std=c++14 in CMAKE_CXX_FLAGS was removed in favor of the more generic set_target_properties() which resolves a build issue where cmake would add -std=c++11 in addition to -std=c++14. The namespace xt was removed inside the benchmark to put the benchmark methods into global namespace.

Not all methods are consistently implemented for all libraries, which is a bit sad, but we may further extend the benchmark in the future.

Please review and suggest changes!

wolfv commented 5 years ago

looks very good to me! Maybe we should even change the name ;)

emmenlau commented 5 years ago

I've seen your older branch https://github.com/QuantStack/xtensor-benchmark/tree/fix_for_15_06 with minor extensions for the benchmark. Is it deprecated or should we try to include it in the update?

wolfv commented 5 years ago

We can add them in at a later stage