search

xtensor-stack / xtensor-blas

BLAS extension to xtensor
BSD 3-Clause "New" or "Revised" License
158 stars 55 forks source link

Build fails when I tried to disable exceptions with XTENSOR_DISABLE_EXCEPTIONS #171

Closed luk036 closed 3 years ago

luk036 commented 4 years ago

When I tried to disable exceptions by setting the XTENSOR_DISABLE_EXCEPTIONS macro, I found that xtensor-blas` did not follow the rule. When I replace the statement:

throw std::runtime_error(

with

XTENSOR_THROW(std::runtime_error,

in all files, it works.

JohanMabille commented 4 years ago

Thanks for reporting. That's indeed a feature we forgot to implement in xtenosr-blas.

JohanMabille commented 3 years ago

Fixed in #172