search

xtensor-stack / xtensor-blas

BLAS extension to xtensor
BSD 3-Clause "New" or "Revised" License
155 stars 54 forks source link

Determinant example documentation fix #192

Closed tatatupi closed 3 years ago

tatatupi commented 3 years ago

The determinant of the example is supposed to be zero, which is the output of xt::linalg::det(a). And for zero determinant matrices, the sign is 0 and logdet is -inf.

wolfv commented 3 years ago

Thanks! How about using a different example that gives nicer results?

tdegeus commented 3 years ago

I agree @wolfv we should use something that is well-determined. The current examples may give unneeded confusion...

tdegeus commented 3 years ago

See https://github.com/xtensor-stack/xtensor-blas/issues/191 . The current example is terrible, because it involves taking log(0), which we really shouldn't do, for sure not in an example.

tatatupi commented 3 years ago

@tdegeus @wolfv done! Check if this example suffices.

JohanMabille commented 3 years ago

@tatatupi thanx!

The issues on the CI are due to the removal of gcc-7 and gcc-8 from the defualt install. I will fix them in a dedicated PR.