labad: Renamed 'small' to 'smallv' to avoid problems with define in rpcndr.h on MSVC

xtensor-stack / xtensor-blas

BLAS extension to xtensor

BSD 3-Clause "New" or "Revised" License

155 stars 54 forks source link

labad: Renamed 'small' to 'smallv' to avoid problems with define in rpcndr.h on MSVC #204

Closed emmenlau closed 2 years ago

emmenlau commented 2 years ago

This PR solves a similar problem as https://github.com/xtensor-stack/xtensor-blas/pull/149 before, again on MSVC. This time the error comes from the header C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared\rpcndr.h on MSVC that has a define

#define small char

which breaks arguments in labad.h and labad.tcc.

emmenlau commented 2 years ago

This should be pretty harmless for a quick merge... :-)

JohanMabille commented 2 years ago

Thanks, sorry for the delay !