search

xtensor-stack / xtensor-fftw

FFTW bindings for the xtensor C++14 multi-dimensional array library
BSD 3-Clause "New" or "Revised" License
48 stars 16 forks source link

Allow xtensor-fftw to build with -fno-exceptions #46

Closed kokarez closed 4 years ago

kokarez commented 4 years ago

This is the next step after: https://github.com/xtensor-stack/xtensor/pull/1801

SylvainCorlay commented 4 years ago

I left one more minor comment, but this looks good to me.

Regarding the iostream inclusion, I think that the same thing could be done in xtensor core. (adding a #include <iostream> if XTENSOR_DISABLE_EXCEPTIONS is set.)

SylvainCorlay commented 4 years ago

Thanks @kokarez!