search

xtensor-stack / xtensor-python

Python bindings for xtensor
BSD 3-Clause "New" or "Revised" License
347 stars 58 forks source link

fix memory leaks in pytensor constructor and copy constructor #157

Closed wolfv closed 6 years ago

wolfv commented 6 years ago

This should fix #156 (the leak was in the copy constructor of pytensor, it's fine with std::move into the tuple).

Thanks for the great bug report @daniel-ziegler – would be cool if you could confirm that this solves your issue.

daniel-ziegler commented 6 years ago

Yep, looks like the problem is solved -- thanks!

daniel-ziegler commented 6 years ago

Are you planning on putting out a 0.19.1 release for this? I think this is a pretty serious issue -- my jobs were leaking tens of gigabytes per hour and couldn't run to completion, and I spent over a day narrowing down the issue, thinking the whole time I was using shared_ptr wrong or something.

wolfv commented 6 years ago

Thanks for the reminder, you're right we should have made a release a week ago -- will do it now!

wolfv commented 6 years ago

Release is out on conda-forge! BTW if you ever have quick questions or remarks, we also try to be very active on our gitter channel: gitter.im/QuantStack/Lobby would be cool to hear what you're doing with xtensor :)