search

xtensor-stack / xtensor-python

Python bindings for xtensor
BSD 3-Clause "New" or "Revised" License
347 stars 58 forks source link

Explicit long long allocator instantiation #197

Closed PerretB closed 5 years ago

PerretB commented 5 years ago

This fixes undefined symbol issues when building on the manylinux1 docker image (with gcc 7.2).

SylvainCorlay commented 5 years ago

Thanks for the PR. In xtensor core we have been maintaining a list of compiler workarounds. It may be interesting to do the same with xtensor-python if we have specific workarounds here.

PerretB commented 5 years ago

I can add a "Compiler Workarounds" page in the "Developer zone" of the doc. However, I am not quite sure of the range of affected compiler. @JohanMabille suggested me this patch in gitter when I described the problem and he told that it had already experienced something similar with xtensor-r. Johan do you have a more precise idea on affected compilers ?

JohanMabille commented 5 years ago

@SylvainCorlay correct me if I'm wrong, but this affects all the tested versions of gcc (from 4.9 up to 7.2). We haven't tested with gcc 8 and gcc 9. Let's say all versions are affected for now, we can refine later. Clang and MSVC are not affected.

SylvainCorlay commented 5 years ago

Yep, maybe worth mentioning GCC without specifying a version then.

SylvainCorlay commented 5 years ago

Thanks @PerretB !