search

xtensor-stack / xtensor-python

Python bindings for xtensor
BSD 3-Clause "New" or "Revised" License
351 stars 58 forks source link

Add python packaging. #236

Closed StefanUlbrich closed 2 years ago

StefanUlbrich commented 4 years ago

Installs headers via pip. Suitable for rapidly writing packages. Modified from the pybind11. Xtensor itself should be packaged and dded as a dependency too.

tdegeus commented 4 years ago

I think this is a great idea, which I do in my shadow package as well : https://github.com/tdegeus/pyxtensor . What do others think ? @JohanMabille @SylvainCorlay @wolfv

JohanMabille commented 4 years ago

To sum up #96, the idea would be to keep this repo pure C++ and add a new repo (xtensor.py) that would contain the pure python stuff. The python package would vendor all dependencies (xtensor, xsimd and xtl). This would be consistent with what we do for the R and Julia bindings.

tdegeus commented 4 years ago

Makes sense @JohanMabille . Will be much easier to maintain and ship. So all for it!

tdegeus commented 4 years ago

Regarding the name xtensor.py, wouldn't the . cause problems e.g. in packaging?

tdegeus commented 4 years ago

Ah, it seems from other packages that you have experience with it. I will try to allocate some time for this soon