search

xtensor-stack / xtensor-python

Python bindings for xtensor
BSD 3-Clause "New" or "Revised" License
345 stars 58 forks source link

Update CMakeLists to correctly find pybind11 alias targets #242

Closed nickrobison-usds closed 3 years ago

nickrobison-usds commented 4 years ago

When building xtensor-python and pybind11 as cmake submodule projects, the pybind aliased targets are not discovered correctly.

This PR adds an additional check to also look for the pybind11:headers aliased target and set the values accordingly.

tdegeus commented 3 years ago

I wonder if this is not more an issue of pybind11? Why is the target not defined?

tdegeus commented 3 years ago

(rerunning CI)

tdegeus commented 3 years ago

Do we care about the CI configuration failures @JohanMabille ? (Also maybe we should fix, what's holding me back is that I'm more of a GitHub Action person ;))

tdegeus commented 3 years ago

rerunning CI

JohanMabille commented 3 years ago

Do we care about the CI configuration failures @JohanMabille ?

Yes we do ;)

tdegeus commented 3 years ago

That's why I fixed them ;)