search

xtensor-stack / xtensor-python

Python bindings for xtensor
BSD 3-Clause "New" or "Revised" License
345 stars 58 forks source link

Use FindPython's numpy component to find numpy include directories #296

Closed dokempf closed 6 months ago

dokempf commented 8 months ago

The current way how numpy is searched for depends on the deprecated FindPythonInterp that is slowly being phased out (see https://cmake.org/cmake/help/latest/module/FindPythonInterp.html). Luckily, the replacement FindPython offers an out-of-the-box solution to find the NumPy headers which allows great simplification of the xtensor-python CMake code. The only downside is that it requires bumping the required CMake version to 3.14.

JohanMabille commented 6 months ago

Thanks a lot! And sorry for the time it took to get in.