xtensor-stack / xtensor-python

Python bindings for xtensor
BSD 3-Clause "New" or "Revised" License
345 stars 58 forks source link

only search for numpy when the numpy-include directory is not passed #297

Closed DerThorsten closed 6 months ago

DerThorsten commented 6 months ago

In the emscripten / wasm case we cannot call the default find_package(NumPy ${NUMPY_REQUIRED_VERSION} REQUIRED) since this tries to call a non-existing python executable for the emscripten-wasm32 platform (we only have a python library for that platform). Therefore we pass NUMPY_INCLUDE_DIRS explicitly when building for wasm.

JohanMabille commented 6 months ago

Superseded with #305