search

xtensor-stack / xtensor-python

Python bindings for xtensor
BSD 3-Clause "New" or "Revised" License
345 stars 58 forks source link

xtensor cmake variables do not match variables in CMakeLists.txt #302

Open mircomarahrens opened 6 months ago

mircomarahrens commented 6 months ago

Including this project via add_subdirectory(path/to/xtensor/python) leads to 

[cmake] ERRORMismatch xtensor versions. Found '..' but requires: '0.24.0'

at the cmake configuration step.

The variables ${XTENSOR_VERSION_MAJOR}, ${XTENSOR_VERSION_MINOR}, ${XTENSOR_VERSION_PATCH} seems to be wrong in https://github.com/xtensor-stack/xtensor-python/blob/a0f1bb632ff3ea7b6c450847d982e2e3ef39fc80/CMakeLists.txt#L37. I don't know why yet, but XTENSOR in the variables is in lower case here,

[cmake] -- xtensor_VERSION_MAJOR=0
[cmake] -- xtensor_VERSION_MINOR=24
[cmake] -- xtensor_VERSION_PATCH=6