Homogenize load_csv and load_npy

xtensor-stack / xtensor

C++ tensors with broadcasting and lazy computing

BSD 3-Clause "New" or "Revised" License

3.34k stars 399 forks source link

Homogenize load_csv and load_npy #1143

Open wolfv opened 6 years ago

wolfv commented 6 years ago

Currently, load_csv takes a istream and load_npy takes a std::string for the filename. Note that the methods in xtensor-io also take a string filename.

We should homogenize the interfaces so that:

load_* and dump_* takes a filename
loads_* and dumps_* take a stream ? -- to be discussed
and then also document how to create a stringstream for feeding strings as input

We should take this into considerat

xiuliren commented 5 years ago

I was confused by the interface, it takes some time to figure it out. It would be nice to be consistent and have documentation/examples.

SylvainCorlay commented 5 years ago

Thanks @jingpengw let us know if you feel like giving it a stab!

liurui39660 commented 3 years ago

Yes, this is quite annoying when transferring from numpy to xtensor. Is there any plan for this issue?