xtermjs / xterm.js

A terminal for the web
https://xtermjs.org/
MIT License
16.99k stars 1.59k forks source link

Uncaught TypeError: Cannot read property '2' of undefined #1281

Closed RalphHogenbirk closed 6 years ago

RalphHogenbirk commented 6 years ago

I'm using xterm for the opensource plugin 'Pymakr' in Atom. It's used to connect to the Pycom boards using the micropython REPL. It's working great, but once in a while this error pops up a few times in a row. Multiple users are reporting it and I've seen it a few times as well but it's solved after a reboot and doesn't happen again for a long time.

Now, I don't know if this is a bug in the xterm lib or that I'm doing something wrong when writing data to the terminal. I'm just posting here to be sure.

At C:\Users\<USER>\.atom\packages\Pymakr\node_modules\xterm\lib\SelectionManager.js:244

TypeError: Cannot read property '2' of undefined
    at SelectionManager._onSingleClick (/packages/Pymakr/node_modules/xterm/lib/SelectionManager.js:244:17)
    at SelectionManager._onMouseDown (/packages/Pymakr/node_modules/xterm/lib/SelectionManager.js:201:22)
    at /packages/Pymakr/node_modules/xterm/lib/SelectionManager.js:51:90)

Details

Steps to reproduce

Unknown

Tyriar commented 6 years ago

This is fixed in v3

RalphHogenbirk commented 6 years ago

Thanks @Tyriar, will start implementing v3 soon.