HTML and string serializer doesn't support underline styles and color - Githubissues

xtermjs / xterm.js

A terminal for the web

https://xtermjs.org/

MIT License

17.63k stars 1.63k forks source link

HTML and string serializer doesn't support underline styles and color #4528

Open Tyriar opened 1 year ago

Tyriar commented 1 year ago

https://github.com/xtermjs/xterm.js/blob/7460782494ceaa48271105c9062a0aaab1d212aa/addons/xterm-addon-serialize/src/SerializeAddon.ts#L264-L271

https://github.com/xtermjs/xterm.js/blob/913cb2586301d3e8322594c2bf08c0ea7d8468c9/addons/xterm-addon-serialize/src/SerializeAddon.ts#L626-L633

How it's handled in dom renderer:

https://github.com/xtermjs/xterm.js/blob/913cb2586301d3e8322594c2bf08c0ea7d8468c9/src/browser/renderer/dom/DomRendererRowFactory.ts#L171-L187

jerch commented 1 year ago

Sidenote - same with OSC8 link handling.

Tyriar commented 1 year ago

👉 https://github.com/xtermjs/xterm.js/issues/4531