search

xtermjs / xterm.js

A terminal for the web
https://xtermjs.org/
MIT License
17.68k stars 1.63k forks source link

Add cursorStyleInactive option #4566

Closed Tyriar closed 1 year ago

Tyriar commented 1 year ago

Follow up to https://github.com/xtermjs/xterm.js/pull/4443

Since we reverted how it used to be (which I still think is the right default), some embedders/users may want it the old way still. We can solve this for everyone by adding a cursorInactiveStyle as suggested by @boettges in https://github.com/xtermjs/xterm.js/pull/4443#issuecomment-1595056304. The name cursorInactiveStyle aligns with selectionInactiveBackground

To implement this you would need to:

  1. Add the new option to xterm.d.ts, options service, etc.
  2. Implement it for dom, canvas and webgl renderers
tisilent commented 1 year ago

try try

tisilent commented 1 year ago

Oh, my! Not implementing selectionInactiveBackground..

Tyriar commented 1 year ago

@tisilent no need to touch the selection ones, they are just used as an example to ensure we're following the right naming style:

selectionInactiveBackground and cursorInactiveStyle