OSC hyperlinks don't work for certain formats

xtermjs / xterm.js

A terminal for the web

https://xtermjs.org/

MIT License

17.43k stars 1.62k forks source link

OSC hyperlinks don't work for certain formats #4916

Closed Tyriar closed 5 months ago

Tyriar commented 9 months ago

VS Code issue: https://github.com/microsoft/vscode/issues/170963

Code pointer: https://github.com/xtermjs/xterm.js/blob/88ba66d00bb848569e867fea894d444defee69b5/src/browser/OscLinkProvider.ts

jerch commented 9 months ago

@Tyriar Cant repro from the given examples, not in master and not in vscode 1.82. Maybe it already got fixed? Note that I have some issues to understand the issue description :sweat_smile:

Tyriar commented 5 months ago

Think I can repro:

The link keeps going to AFTER_LINK and beyond