search

xtermjs / xterm.js

A terminal for the web
https://xtermjs.org/
MIT License
17.33k stars 1.61k forks source link

Update global object fix #4940

Closed octoclonius closed 4 months ago

octoclonius commented 7 months ago

The changes are to the webpack.config.js files in each of the addon's folders. I set the global object to globalThis. I think this should fix the addons because when I import them, I get an error saying self is not defined.

GoodbyeNJN commented 5 months ago

Is there any progress on this PR? I am also troubled by this problem, recompiling addon after using this patch works fine for me.

FRSgit commented 5 months ago

@Tyriar Do you think this PR is something that could be merged in nearest future? Is anything needed here to unblock it?

It's blocking usage of the library with nuxt (in SSR context it tends to fail).