Closed arencoskun closed 6 months ago
Thanks for the feedback, working on it
@arencoskun With fixing the remaining linter errors, this LGTM 👍
Oops, forgot to fix those. Will work on it in a few moments
@arencoskun ~The linter is still nagging about a whitespace in xterm.d.ts
.~ (guess you were faster :smile_cat: )
Oh and btw - the declaration also needs to be added to xterm-headless.d.ts
(sorry forgot about that before).
@arencoskun ~The linter is still nagging about a whitespace in
xterm.d.ts
.~ (guess you were faster 😸 )Oh and btw - the declaration also needs to be added to
xterm-headless.d.ts
(sorry forgot about that before).
No problem, also adding that
Sorry, forgot to mark as draft
Whoopsie - the headless API-bundling class in src/headless/public/Terminal.ts
would also need the impl forwarding similar to browser/public/Terminal.ts
.
(Why? - We basically maintain 2 versions of xterm.js Terminal class - one for browser and for headless nodejs usage. So parts of the API bundling is doubled here.)
Whoopsie - the headless API-bundling class in
src/headless/public/Terminal.ts
would also need the impl forwarding similar tobrowser/public/Terminal.ts
.(Why? - We basically maintain 2 versions of xterm.js Terminal class - one for browser and for headless nodejs usage. So parts of the API bundling is doubled here.)
Thanks for the info, I've been busy tonight but most probably tomorrow I'll finish it off. (Also, seems like you can't mark PRs as drafts from the mobile app. That's weird 😀 )
@Tyriar Could you also review this PR? Because of the API addition I dont want to merge it w'o being reviewed by you.
This PR adds an input method which takes data as the parameter as described in the issue. If there are any issues, you can point it out and I'll fix it.
(Sorry if there's an issue, I am a beginner.)
Fixes #4948.