xtermjs / xterm.js

A terminal for the web
https://xtermjs.org/
MIT License
17.52k stars 1.62k forks source link

Support semi-colons in OSC 8 hyperlink URIs #5003

Closed josiahhudson closed 5 months ago

josiahhudson commented 6 months ago

Original code performed a simple data.split(';') which split on every ";" in the string. This new version treats the first ";" as the only split character, ensuring that params are properly separated from the URI.

josiahhudson commented 6 months ago

lol, feedback makes sense. Happy to make the changes. I struggled to find a good place to put a test when I was looking at this, but I was short on time so I'll give it another go. I'll do it earlier if I can, but I may not have time to look at this again till Friday.